NCO-56 fix warnings in build#51
Merged
Merged
Conversation
Collaborator
davidkelly
commented
Mar 20, 2026
davidkelly
commented
- Added .editorconfig - can extend this as needed
- Ran dotnet format, fixing whietspace, unused usings, etc...
- Fixed other warnings as well
- Removed redundant package references (since we are .NET 10 only)
- Unused import in proto files remain until we go to the source of the files and fix them there
* Added .editorconfig - can extend this as needed * Ran dotnet format, fixing whietspace, unused usings, etc... * Fixed other warnings as well * Removed redundant package references (since we are .NET 10 only) * Unused import in proto files remain until we go to the source of the files and fix them there
Collaborator
Author
|
Oh - forgot the .editorconfig file. Actually - worth a discussion before I add it. Can keep it local for my own linting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.